Repository navigation
darwin.libcxx: 21.1.6+apple-sdk-26.5 -> 22.1.6+apple-sdk-27.0 - #567433
Merged
Merged
Conversation
nixpkgs-ci
Bot
requested review from
a team and
balsoft
and removed request for
a team
September 27, 2026 11:08
nixpkgs-ci
Bot
added
10.rebuild-linux: 501+
reckenrode
force-pushed
the
push-kktznzxmyyyn
branch
2 times, most recently
from
October 9, 2026 04:05
eb54a27 to
be6a37c
Compare
Scrumplex
approved these changes
Oct 10, 2026
Scrumplex
left a comment
Scrumplex
left a comment
Member
There was a problem hiding this comment.
Changes LGTM. I don't have enough experience to merge this though.
in-tree patch is functionally identical to https://github.com/llvm/llvm-project/commit/a558d656043734cc4d02e0a0a12e4c308c28f8c7.diff
Requesting review from @NixOS/llvm again to get some eyes on this before the feature freeze in two weeks.
For the release:
IMO the changes to LLVM are non-breaking so we can set the dead line for this to the regular feature freeze are libcxx changes might be breaking.
nixpkgs-ci
Bot
added
the
12.approvals: 1
booxter
approved these changes
Oct 11, 2026
booxter
left a comment
booxter
left a comment
Contributor
There was a problem hiding this comment.
Confirmed I can build and compile a simple C++ program with it.
| @@ -1,16 +1,16 @@ | |||
| { | |||
| # Use the text-based stubs and headers from the latest SDK (currently 15.x). This is safe because | |||
| # Use the text-based stubs and headers from the latest SDK (currently 27.x). This is safe because | |||
Contributor
There was a problem hiding this comment.
nit: this seems to be a comment which is prone to rot. I'd drop the version instead.
nixpkgs-ci
Bot
added
12.approvals: 2
reckenrode
force-pushed
the
push-kktznzxmyyyn
branch
from
October 11, 2026 03:24
be6a37c to
d1c9269
Compare
These specializations are technically UB. They were accepted by older versions of libc++, but libc++ 22 is more strict, which causes the current LLVM version to fail to build. Because Darwin links against the system libc++, it will need these specializations fixed when it updates to the system libc++ headers in the 27.0 SDK, which come from LLVM 22.
reckenrode
force-pushed
the
push-kktznzxmyyyn
branch
from
October 11, 2026 11:08
d1c9269 to
68d4b6e
Compare
8 of 19 tasks
3 of 13 tasks
nixos-cuda-channel-updater Bot
pushed a commit
to nixos-cuda/nixpkgs
that referenced
this pull request
Oct 23, 2026
…sult This fixes building Lix on Darwin after NixOS#567433.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #564039, it’s time to update the system libc++ on Darwin. This will be needed by Swift 6.4 to link against the 27.0 SDK. Otherwise, using C++ with the 27.0 SDK will fail to compile.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.